Skip to content

refactor(ci): auto-run workflow#4292

Open
Ma77Ball wants to merge 9 commits intoapache:mainfrom
Ma77Ball:ci/AutoRunWorkflow
Open

refactor(ci): auto-run workflow#4292
Ma77Ball wants to merge 9 commits intoapache:mainfrom
Ma77Ball:ci/AutoRunWorkflow

Conversation

@Ma77Ball
Copy link
Contributor

What changes were proposed in this PR?

The build workflow now runs automatically for all PRs. All three build jobs (frontend, scala, python) trigger directly on push, pull_request, and workflow_dispatch events, making CI faster and easier to reason about for all contributors.

Any related issues, documentation, discussions?

Closes: #4290

How was this PR tested?

Verified that all three build jobs (frontend, scala, python) trigger automatically on pull request open, push, and synchronize events.

Was this PR authored or co-authored using generative AI tooling?

Resolved comments with Claude Sonnet 4.6

@github-actions github-actions bot added the ci changes related to CI label Mar 13, 2026
@Ma77Ball
Copy link
Contributor Author

@Yicong-Huang to address this comment (#4278 (comment)):

The core issue is that the workflow currently has no pull_request trigger at all, which is why it doesn't run for anyone — committers or not. The fix simply adds the pull_request trigger with the standard event types (opened, synchronize, reopened), which is what makes GitHub automatically run the workflow for all PRs, including forks.

The reason this works for fork contributors without explicit approval is that adding pull_request (not pull_request_target) to the trigger is GitHub's built-in mechanism for running CI on PRs. GitHub handles fork isolation automatically by running the workflow with read-only tokens and no access to secrets. No committer approval step is needed because GitHub's own sandboxing is what keeps fork PRs safe.

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang to address this comment (#4278 (comment)):

The core issue is that the workflow currently has no pull_request trigger at all, which is why it doesn't run for anyone — committers or not. The fix simply adds the pull_request trigger with the standard event types (opened, synchronize, reopened), which is what makes GitHub automatically run the workflow for all PRs, including forks.

Sorry I am more confused. We had pull_request: so it will trigger for ALL types of events from pull_request. And the CIs were automatically triggered for committers.

But the new change limits it to [open, sychronize, reopened] which are typically more restricted.

I couldn't understand why it can resolve the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-run CI build workflow for all PRs

2 participants