-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-55242][PYSPARK] Handle np.ndarray elements in list-valued columns when converting from pandas #55196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azmatsiddique
wants to merge
11
commits into
apache:master
Choose a base branch
from
azmatsiddique:SPARK-55242-pyspark-pandas-np-array-from-list
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+173
−57
Open
[SPARK-55242][PYSPARK] Handle np.ndarray elements in list-valued columns when converting from pandas #55196
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1fc2051
[SPARK-55242][PYSPARK] Handle np.ndarray elements in object-dtype col…
ef76d1f
[SPARK-55242][PYTHON] Refine handling of np.ndarray elements and supp…
3d3acd9
[SPARK-55242][PYTHON] Remove unused numpy import in string_ops.py to …
d210f99
[SPARK-55242][PYTHON] Convert np.ndarray elements to lists in DataTyp…
ffdc968
[SPARK-55242][PYTHON] Reformat complex ops test for ruff compliance
de4df8e
[SPARK-55242][PYTHON] Add graceful skip for Connect parity test invol…
ed3477e
[SPARK-55242][PYTHON] Fix unsupported sort_values(key=...) in complex…
7b19dc0
Address review feedback: recursive ndarray conversion and narrow exce…
4dde95d
Fix ruff formatting issue in base.py
d4006f9
Fix complex_psdf TypeError by using ps.DataFrame instead of concat
f305707
Fix Pandas 3 ambiguity in test comparison and fix complex_psdf by con…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The try/except block below it unreachable for object-dtype columns. And since ndarrays can only exist in object-dtype columns , the try/except is effectively unreachable. Would suggest removing it and keeping just the if branch for clarity.