Skip to content

Fix wrong process id format #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wu-sheng merged 1 commit into from
Apr 21, 2025
+3 −1
Merged

Fix wrong process id format #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ Release Notes.

### Bug Fixes

* Fix wrong process id format by @mrproliu in https://github.com/apache/skywalking-cli/pull/215

0.14.0
------------------

Expand Down
2 changes: 1 addition & 1 deletion internal/commands/interceptor/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func parseProcess(required bool, idFlagName, nameFlagName, instanceIDFlagName st
if instanceID == "" {
return fmt.Errorf(`"--%s" is specified but its related service name or id is not given`, nameFlagName)
}
id = fmt.Sprintf("%x", sha256.Sum256([]byte(fmt.Sprintf("%s_%s", instanceID, name))))
id = fmt.Sprintf("%x", sha256.Sum256([]byte(fmt.Sprintf("%s_%s", name, instanceID))))
}

return ctx.Set(idFlagName, id)
Expand Down
Loading