[refactor] Use isEmpty() instead of size() == 0 in PopBufferMergeService#10153
Open
Senrian wants to merge 1 commit intoapache:developfrom
Open
[refactor] Use isEmpty() instead of size() == 0 in PopBufferMergeService#10153Senrian wants to merge 1 commit intoapache:developfrom
Senrian wants to merge 1 commit intoapache:developfrom
Conversation
Use isEmpty() method for better readability and performance. Signed-off-by: Senrian <senrian@github.com>
Contributor
|
Hi @Senrian, thank you very much for submitting the pull requests. Could you squash these refactoring PRs into a single PR? I’ll close some of the current ones first—there are too many and it’s flooding the feed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use isEmpty() method for better readability and performance.
Signed-off-by: Senrian senrian@github.com