fix: use currOffset instead of nextOffset when delivery fails (ISSUE #9249)#10117
Open
Senrian wants to merge 3 commits intoapache:developfrom
Open
fix: use currOffset instead of nextOffset when delivery fails (ISSUE #9249)#10117Senrian wants to merge 3 commits intoapache:developfrom
Senrian wants to merge 3 commits intoapache:developfrom
Conversation
…pache#9249) When message delivery fails in ScheduleMessageService.DeliverDelayedMessageTimerTask, the offset parameter passed to scheduleNextTimerTask was incorrect. Using nextOffset would skip the current message and potentially lose messages. This fix changes to use currOffset to retry the current message immediately. Compare with version 4.9.8 which uses nextOffset in the loop but correctly passes currOffset when delivery fails.
Contributor
|
The code doesn't match the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When message delivery fails in ScheduleMessageService.DeliverDelayedMessageTimerTask, the offset parameter passed to scheduleNextTimerTask was incorrect. Using nextOffset would skip the current message and potentially lose messages.
Fix
This fix changes to use currOffset to retry the current message immediately.
Verification
Fixes #9249