[fix][test] Fix flaky PersistentTopicTerminateTest.testRecoverAfterTerminate#25345
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
[fix][test] Fix flaky PersistentTopicTerminateTest.testRecoverAfterTerminate#25345merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
…rminate The test called skipAllMessages to advance the cursor but the consumer had already received the messages without acknowledging them. The skipAllMessages call can race with the consumer's internal state. Use acknowledgeCumulative on the last message instead, which properly advances the mark-delete position. Also increase the Awaitility timeout to 30s for the ledger trim.
merlimat
force-pushed
the
fix/flaky-PersistentTopicTerminateTest
branch
from
92a8472 to
5132522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flaky test failure
Summary
PersistentTopicTerminateTest.testRecoverAfterTerminateby increasing the Awaitility timeout from 10s (default) to 30s.Documentation
doc-not-needed(Your PR doesn't need any doc update)
Matching PR in forked repository
No response
Tip
Add the labels
ready-to-testandarea/testto trigger the CI.