-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve][pip] PIP-347: add role field in consumer's stat #22564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3bb460b
add pip-347.
thetumbled ebccecd
add discussion link.
thetumbled 18aa29e
add conf.
thetumbled 3180731
change doc.
thetumbled d356271
update doc.
thetumbled 9f351fc
update doc.
thetumbled dd7865d
not sensitive.
thetumbled File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
|
|
||
| # PIP-347: add role field in consumer's stat | ||
|
|
||
| # Background knowledge | ||
|
|
||
| During the operation and maintenance process, there are many users asking administrator for help to find out the consumers of a topic and notify them about the business change. | ||
| Administrators can call `bin/pulsar-admin topics partitioned-stats` to find out the `ip:port` of the consumers, but no role info. So administrators need to take a lot of time to | ||
| communicate with users to find out the owner based on the `ip:port`. It's a troublesome work and low efficiency, or even can't find out the owner. | ||
|
|
||
| # Motivation | ||
|
|
||
| This pip can help to solve such kind of problem. By adding a field `appId` in the consumer's stat. | ||
| For cluster with JWT-based authentication, the administrator can find out the owner of the consumer directly. | ||
| It can save a lot of time and improve the efficiency of the operation and maintenance process. | ||
|
|
||
| # Goals | ||
|
|
||
| - help administrator to find out the owner of the consumer for cluster with JWT-based authentication. | ||
|
|
||
| # Detailed Design | ||
|
|
||
| ## Design & Implementation Details | ||
| - Add a field `appId` in the consumer's stat, which can show the owner of this consumer for JWT-based authentication users. | ||
|
|
||
| # Backward & Forward Compatibility | ||
|
|
||
| Fully compatible. | ||
|
|
||
| # General Notes | ||
|
|
||
| # Links | ||
|
|
||
| <!-- | ||
| Updated afterwards | ||
| --> | ||
| * Mailing List discussion thread: https://lists.apache.org/thread/p9y9r8pb7ygk8f0jd121c1121phvzd09 | ||
| * Mailing List voting thread: | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.