PartitionStatistics support totalBuckets #6964
Conversation
jianguotian
changed the title
jianguotian
force-pushed
the
add_bucket_cnt_partition_stats
branch
from
9441daf to
541ea26
Compare
jianguotian
force-pushed
the
add_bucket_cnt_partition_stats
branch
from
a0c7e51 to
9e42afc
Compare
jianguotian
changed the title
jianguotian
changed the title
|
Is this change compatible?
Perhaps you need to conduct some tests to ensure |
I have test old version RESTCatalog listPartitions request to DLF catalog server(which return Partition with new totalBuckets field), server response can be deserialized into Partition successfully. @JsonIgnoreProperties annotation and DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES ensure that. |
| protected final long lastFileCreationTime; | ||
|
|
||
| @JsonProperty(FIELD_TOTAL_BUCKETS) | ||
| protected final int totalBuckets; |
There was a problem hiding this comment.
Please add comments to explain value when missing.
There was a problem hiding this comment.
Please add comments to explain value when missing.
done
| protected final long lastFileCreationTime; | ||
|
|
||
| @JsonProperty(FIELD_TOTAL_BUCKETS) | ||
| protected final int totalBuckets; |
There was a problem hiding this comment.
Also add test to missing case.
There was a problem hiding this comment.
add PartitionStatisticsTest
|
+1 |
2 participants
Purpose
PartitionStatistics add totalBuckets field, get value from ManifestEntry.totalBuckets()
Tests
org.apache.paimon.flink.RESTCatalogITCase#testTotalBucketsStatistics:
verify totalBuckets stats for 3 bucket mode
API and Format
Partition and PartitionStatistics add new totalBuckets field
Documentation
rest-catalog-open-api doc:
Partition and PartitionStatistics add totalBuckets field