feat(bindings/c): Add ReadOptions support for new options API #7106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
dosubot
bot
added
size:L
Contributor
a simpler way is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7105.
Rationale for this change
This PR implements ReadOptions support in C bindings as part of the migration to the new options API outlined in RFC-6213 (#6213).
Are there any user-facing changes?
In my view, no. What I think need to be notice is that, C doesn't have the type Timestamp. So I use string as alternative and parse it using the method
from_strof Timestape, which may give user an different experience with usingcoreI do only finish
read_optionscurrently and lack ofreader_options. I want to know if I can do this work and do I do it right so that I can go on with confidence.AI Usage Statement
provide some knowledge for debug =)