fix: close issue #6855 try to ignore gil hang #6859
Draft
+149
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
dosubot
bot
added
size:L
Contributor
Author
|
@messense I am not sure its fully right can you help to check? Thank you very much |
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
messense
approved these changes
Dec 3, 2025
Member
messense
left a comment
messense
left a comment
There was a problem hiding this comment.
Makes sense, I think generally we should release GIL when doing potential time consuming network requests, so most Operator methods should also do this.
Xuanwo
reviewed
Dec 3, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
There are two concerns so far:
- I used to expect that our Rust code wouldn’t be tied to the Py GIL by default, but it seems it is. We could use more details on this.
- Having
py.detacheverywhere doesn’t seem ideal. Let’s find a way to make it more maintainable.
Contributor
Author
|
yes I need to reproducer does on a real env, to make that a responsibility fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6855
Rationale for this change
What changes are included in this PR?
all python method use https://pyo3.rs/v0.27.1/parallelism.html
also add tests for it
before the patch the gil tests are failed
after this patch gil tests passed
let see what will happen in CI
Are there any user-facing changes?