feat(services/azblob): support use_fabric_endpoint config #6530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Member
|
This'll be reviewed after upgrading reqsign. |
dosubot
bot
added
size:L
jackye1995
force-pushed
the
azure-missing-features
branch
from
9285657 to
dc651c7
Compare
The struct already has #[serde(default)] so individual fields don't need it 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
jackye1995
changed the title
Contributor
Author
|
@Xuanwo thanks for taking a look. I removed all the auth-related chanages from the PR, will do it after reqsign upgrade. This PR now only contains the missing support of a |
Member
I shares the same concern like #6531 (comment) |
Contributor
Author
|
I see, in that case I will close this one since this can be achieved by setting the endpoint directly. For S3 ones I think they are orthogonal, I replied more details there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
use_fabric_endpointconfig which will set the endpoint to fabric one instead of windows. This config cannot be set together with theendpointconfig.