Skip to content

fix(aliyun-oss): avoid duplicated bucket in canonicalized resource for path-style #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 1 commit into from
Feb 26, 2026
+9 −1
Merged

fix(aliyun-oss): avoid duplicated bucket in canonicalized resource for path-style #692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion services/aliyun-oss/src/sign_request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,15 @@ impl RequestSigner {

// Build resource string
let decoded_path = percent_encoding::percent_decode_str(path).decode_utf8_lossy();
let resource_path = format!("/{}{}", self.bucket, decoded_path);
let authority = req.uri.authority().map(|v| v.as_str()).unwrap_or("");
let is_virtual_host = authority.starts_with(&format!("{}.", self.bucket));

let resource_path = if is_virtual_host {
format!("/{}{}", self.bucket, decoded_path)
} else {
// Path-style addressing already includes bucket in request path: http://endpoint/<bucket>/<object>, do not repeat
decoded_path.to_string()
};

if query_pairs.is_empty() {
resource_path
Expand Down
Loading