Skip to content

Comments

update: bump TextMate to version 0.17.1#9176

Open
BradWalker wants to merge 1 commit intoapache:masterfrom
BradWalker:update_textmate_and_markdown
Open

update: bump TextMate to version 0.17.1#9176
BradWalker wants to merge 1 commit intoapache:masterfrom
BradWalker:update_textmate_and_markdown

Conversation

@BradWalker
Copy link
Member

desc: Update to the latest version of TextMate (0.17.1). In addition, cleanup the ide/textmate.lexer module code.

If this PR targets the delivery branch: don't merge. (full wiki article)

desc: Update to the latest version of TextMate (0.17.1). In addition, cleanup the ide/textmate.lexer module code.
@BradWalker BradWalker self-assigned this Jan 30, 2026
@BradWalker BradWalker added the Code cleanup Label for cleanup done on the Netbeans IDE label Jan 30, 2026
@BradWalker BradWalker modified the milestones: NB29, NB30 Jan 30, 2026
@matthiasblaesing matthiasblaesing added the LSP [ci] enable Language Server Protocol tests label Feb 16, 2026
@apache apache locked and limited conversation to collaborators Feb 16, 2026
@apache apache unlocked this conversation Feb 16, 2026
@matthiasblaesing
Copy link
Contributor

I had a quick look at this and it looks sane from the code perspective. Issues I see:

  • the text in org.eclipse.tm4e.core-0.17.1-license.txt has a header with name "License" this header is a reference to a file in nbbuild/licenses. The verify-libs-and-licenses ant task (you can run that locally yourself. Verifies that the texts match.
  • the license file and the jar file must match in name only differing in the -license injection. So there are two options: You can change the final download name to org.eclipse.tm4e.core-0.17.1.jar (notice the change from underscore to dash). Or you can add a Files: to the org.eclipse.tm4e.core-0.17.1-license.txt file (directly after the Origin header), which get the filename of the jar als value.
  • the updated textmate grammar can't be parsed as it uses regexps not supported by joni (joni has issues with look-behind patterns). These patterns either have to be manually fixed or the original grammer has to be retained for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code cleanup Label for cleanup done on the Netbeans IDE LSP [ci] enable Language Server Protocol tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants