[QDP] Numpy IO support #777
Open
+2,334
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Contributor
|
@ryankert01 thanks for the patch |
Contributor
|
Should we add a file size check like other format to prevent OOM? |
rich7420
reviewed
Jan 3, 2026
| let path = path.as_ref(); | ||
|
|
||
| // Verify file exists | ||
| if !path.exists() { |
Contributor
There was a problem hiding this comment.
I think we could add this path.exists() in other format.
rich7420
reviewed
Jan 3, 2026
|
|
||
| // Flatten to Vec<f64> | ||
| // Handle both C-contiguous (row-major) and Fortran-contiguous (column-major) | ||
| let data = if array.is_standard_layout() { |
Contributor
There was a problem hiding this comment.
I think this one it's great!
Contributor
|
overall LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
ran some benchmark + test(maybe) on colab.
https://colab.research.google.com/drive/1NuAyAFsko3uD8MMBTDQpob4zSxg_GeiC?usp=sharing
Related Issues or PRs
Closes #722
Changes Made
Breaking Changes
Checklist