MAHOUT-743: Add regression test for async amplitude chunk bounds #773
+285
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Rutuja123-dos thanks for the patch , you should aim to dev-qdp branch. |
Contributor
Author
|
@rich7420 thanks for clarification. I will retarget the PR to the dev-qdp branch |
…pache#654) * Add mypy for static type checking Added mypy static type checking to pre-commit hooks. * pre-commit hook: fix Signed-off-by: ryankert01 <ryan980053@gmail.com> * update version and clean-up strings Signed-off-by: ryankert01 <ryan980053@gmail.com> --------- Signed-off-by: ryankert01 <ryan980053@gmail.com>
* Implement T-gate (π/8 gate) across all backends - Add apply_t_gate() method to QuMat class with validation - Implement T-gate support in Qiskit, Cirq, and Amazon Braket backends - Restore T-gate documentation in basic_gates.md to match implementation Fixes apache#681 * Refine T-gate docs and add coverage * chore: satisfy pre-commit hooks
* docs: add missing QuMat APIs * clarify T-gate usage and parameter description * alignment docs/api.md Co-authored-by: 江家瑋 <36886416+JiangJiaWei1103@users.noreply.github.com> --------- Co-authored-by: 江家瑋 <36886416+JiangJiaWei1103@users.noreply.github.com>
Fixes apache#707 (Trying to find some simple issues to help with while hopefully finally finding time to toy with the code over Christmas.)
…d of None (apache#757) * fix the bug * Update documentation to reflect draw_circuit() returns value instead of printing
Rutuja123-dos
force-pushed
the
fix-743-async-amplitude-oob
branch
from
4cd7890 to
c43905d
Compare
guan404ming
reviewed
Jan 1, 2026
Member
guan404ming
left a comment
guan404ming
left a comment
There was a problem hiding this comment.
It looks like this PR includes several changes that are unrelated to its main purpose. Could you please remove those so the scope stays focused? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Adds a regression test to ensure async amplitude encoding respects 'chunk_len'
instead of writing the full 'state_len', preventing out-of-bounds writes for
non-first chunks.
Related Issues or PRs
Changes Made
Breaking Changes
Checklist