[QDP] add Rust Linter to pre-commit hook #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankert01
force-pushed
the
linter-rust
branch
from
75d0868 to
7aef961
Compare
Signed-off-by: Hsien-Cheng Huang <ryankert01@gmail.com>
Contributor
|
I think it's pretty good. thanks for the patch @ryankert01 ! |
Contributor
Author
|
@rich7420 I think it already ran formatting in ci! https://github.com/apache/mahout/actions/runs/20506289497/job/58938406396#step:5:1 |
rich7420
approved these changes
Dec 28, 2025
Contributor
|
All passed locally. |
dentiny
reviewed
Dec 29, 2025
| # Rust Linter | ||
| - repo: local | ||
| hooks: | ||
| - id: rust-fmt |
There was a problem hiding this comment.
There's native rust format precommit hook to use: https://github.com/Mooncake-Labs/moonlink/blob/97f9bd064c2ca2d633afea7c4534e2c662b55c3f/.pre-commit-config.yaml#L6-L9
The benefit of which is we don't need pre-setup in CI (though cargo fmt is built in by default)
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
My bad, we actually be able to config it. Thanks for the suggestion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Related Issues or PRs
Closes #736