refractor(C++): remove hardcoded row group size, keep 64M default#872
Merged
yangxk1 merged 1 commit intoapache:mainfrom Feb 25, 2026
Merged
refractor(C++): remove hardcoded row group size, keep 64M default#872yangxk1 merged 1 commit intoapache:mainfrom
yangxk1 merged 1 commit intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
============================================
+ Coverage 80.21% 80.22% +0.01%
Complexity 615 615
============================================
Files 93 93
Lines 10258 10261 +3
Branches 1050 1050
============================================
+ Hits 8228 8232 +4
+ Misses 1790 1789 -1
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SYaoJun
force-pushed
the
220_row_config
branch
from
59fd227 to
58554b2
Compare
SYaoJun
force-pushed
the
220_row_config
branch
from
58554b2 to
58a62ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
Currently, row group size is hard code: 64 * 1024 * 1024
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?