fix(java): adjust children module version of pom to avoid warning#689
fix(java): adjust children module version of pom to avoid warning#689sanyakapoor27 wants to merge 4 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
===========================================
+ Coverage 59.94% 95.11% +35.16%
===========================================
Files 65 8 -57
Lines 9213 737 -8476
Branches 975 0 -975
===========================================
- Hits 5523 701 -4822
+ Misses 3690 36 -3654 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @sanyakapoor27, thanks for your commit! However, I suggest not adding version constants in all child POMs, as this could make maintenance more difficult. It’s better to remove the version tags from child POMs. |
|
Hi @yecol, thanks for the review! |
|
Thanks for the prompt update! |
|
Hi @sanyakapoor27 , Ubuntu 20.04 LTS runner has been removed on 2025-04-15(link). I will contribute a PR to fix the error. You can rebase the main branch after the updating of GitHub Action Runner : ) |
|
@yecol thanks for the review once again! I had previously updated line 32 of the root POM to 0.12.0-SNAPSHOT, but that led to "[FATAL] Non-resolvable parent POM" errors when building the child modules. This error and the warning mentioned in the issue #688 were gone when the < version> in the child poms also referred to 0.12.0-SNAPSHOT. This can be viewed here: Stack Overflow. In such a case, please let me know what would be the best course of action? |
|
@sanyakapoor27 Hi! The Spark CI has been fixed, could you please rerun the CI workflow? |
|
@sanyakapoor27, do you have time to continue to complete this pr? That has not been updated for too long will be closed |
|
Hi! @yangxk1 i apologise for not getting back to you sooner due to some unforseen commitments, i will update it by this weekend. thanks a lot! |
Reason for this PR
As described in #688, this PR is done to remove the maven warnings due to version property which may break future maven builds.
What changes are included in this PR?
Removed the version property from child modules where it can be inherited from the parent and replaced expressions with constants in .
Are these changes tested?
yes, verified maven build after the changes.
Are there any user-facing changes?
no