fix(core): align count strategy connective steps#3037
Open
contrueCT wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3037 +/- ##
============================================
- Coverage 35.85% 29.70% -6.16%
+ Complexity 338 264 -74
============================================
Files 802 803 +1
Lines 67995 68060 +65
Branches 8902 8908 +6
============================================
- Hits 24381 20216 -4165
- Misses 41008 45526 +4518
+ Partials 2606 2318 -288 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
PR #2993 introduced
HugeCountStrategyto guard HugeGraph against unsafe negative-boundcount().is(P)optimizations.This follow-up ports the upstream TINKERPOP-2911
ConnectiveStephandling into HugeGraph's local strategy, soand()/or()child traversals are rewritten consistently with upstreamCountStrategy.Main Changes
ConnectiveStepseparately when convertingcount().is(0)intonot(...)not(...)using a cloned traversal, instead of only rewriting the tail stepFilterStepconversionand()/or()traversal shapes, including multi-stepwhere(or(...))casesVerifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need