Adds script to help promote RC artifacts & modifies packages for future source releases #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should only move apache-hamilton* artifacts.
This will make it simpler to release things. Since we vote on source releases -- this will make it simpler to do so rather than much post-processing. Note: flit for some reason creates metadata that is ahead of what twine knows about. This then updates the helper to drop worrying about the other artifacts. We'll postprocess them to upload to pypi.
skrawcz
changed the title
We should move files to save on disk space.
We missed this in the initial ASF setup.
elijahbenizzy
approved these changes
Oct 19, 2025
zilto
requested changes
Oct 20, 2025
| """Creates the source tarball, GPG signature, and checksums using `python -m build`.""" | ||
| print("Creating release artifacts with 'python -m build'...") | ||
| files_to_upload = [] | ||
| print("Creating release artifacts with 'flit build'...") |
Contributor
There was a problem hiding this comment.
should we remove the print and use echo in the .sh script instead?
Contributor
Author
There was a problem hiding this comment.
I think this is closer to the code -- so no difference?
skrawcz
commented
Oct 27, 2025
skrawcz
commented
Oct 27, 2025
skrawcz
commented
Oct 27, 2025
skrawcz
commented
Oct 27, 2025
zilto
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only move apache-hamilton* artifacts.
We should only create apache-hamilton artifacts for the source release vote.
We can post-process for upload to pypi.
Also contains update to docs for the release to include links to the downloads.
Changes
How I tested this
Notes
Checklist