Enable conditional command registration. #438
Merged
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwatson
reviewed
Aug 15, 2025
stbischof
force-pushed
the
loglevel
branch
3 times, most recently
from
bf6b61e to
0dc01ce
Compare
tjwatson
reviewed
Aug 15, 2025
stbischof
force-pushed
the
loglevel
branch
2 times, most recently
from
7931daa to
ba5f00e
Compare
tjwatson
approved these changes
Aug 18, 2025
Member
tjwatson
left a comment
tjwatson
left a comment
There was a problem hiding this comment.
Besides minor formatting issues this LGTM
- Add `ds.commands.enabled` property to control command registration. - Update `Activator` to conditionally register component commands. - Extend `ScrConfigurationImpl` to handle `ds.commands.enabled`. - Add MetaType Attreibute definition. Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ds.commands.enabledproperty to control command registration.Activatorto conditionally register component commands.ScrConfigurationImplto handleds.commands.enabled.