fix: emit query/node/{bytes/time} metrics on query failure to data nodes#19453
Merged
jtuglu1 merged 1 commit intoMay 12, 2026
Merged
Conversation
1e2355e to
b17fb8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Failed requests to data nodes (e.g. timeouts) will not log query/node/bytes, query/node/time, nor any backpressure metrics which are all useful in debugging bottlenecks for queries. Make sure these are emitted irrespective of whether the query was successful or not.
Release note
Emit query/node/{bytes/time} and backpressure metrics even on query failure to data nodes.
This PR has: