Skip to content

Conversation

@Shekharrajak
Copy link
Contributor

Enable native execution for Iceberg queries with bucket/truncate/year/month/day/hour transforms in residuals. Row-group filtering skips these predicates but post-scan CometFilter applies them. Provides native performance while maintaining correctness.

Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the scalastyle errors so the tests can run?

@Shekharrajak Shekharrajak force-pushed the feature/non-identity-transform-residuals branch from e9138cd to f41059f Compare January 5, 2026 17:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.55%. Comparing base (f09f8af) to head (f41059f).
⚠️ Report is 822 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/org/apache/comet/rules/CometScanRule.scala 11.11% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2948      +/-   ##
============================================
+ Coverage     56.12%   59.55%   +3.42%     
- Complexity      976     1380     +404     
============================================
  Files           119      167      +48     
  Lines         11743    15497    +3754     
  Branches       2251     2569     +318     
============================================
+ Hits           6591     9229    +2638     
- Misses         4012     4971     +959     
- Partials       1140     1297     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants