refactor(CordovaError): drop netflix/nerror dependency#247
Open
dpogue wants to merge 1 commit intoapache:masterfrom
Open
refactor(CordovaError): drop netflix/nerror dependency#247dpogue wants to merge 1 commit intoapache:masterfrom
dpogue wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 95.40% 95.49% +0.09%
==========================================
Files 20 20
Lines 3917 3953 +36
==========================================
+ Hits 3737 3775 +38
+ Misses 180 178 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erisu
approved these changes
Jan 24, 2026
Member
erisu
left a comment
There was a problem hiding this comment.
Code changes LGTM.
Tests passed with minimum supported Node version.
As there are breaking changes, I would suggest including this with next major release.
While these breaking changes won’t affect Cordova (since that functionality wasn't used), others who use this package directly might be affected (depending on how they use it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
All
Motivation and Context
The
@netflix/nerrorpackage doesn't seem to be actively maintained, and it haslodashas a dependency which is a big source of dependabot security warnings.Description
Implement our own CordovaError mimicking the (few) relevant parts of VError.
There are technically a few breaking changes here, to be discussed whether this needs to wait for a major or not:
err.cause()method to anerr.causegettererr.info()method to anerr.infogetter (unused)err.assignInfo(...)method (unused)assignInfofindCauseByNamehasCauseWithNameerrorFromListerrorForEachisVErrorTesting
Existing tests pass and added test cases to ensure proper code coverage.
Checklist