Skip to content

classify xn--90ae (бг) as a country-code TLD #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebbASF merged 1 commit into from
Jun 23, 2026
+5 −1
Merged

classify xn--90ae (бг) as a country-code TLD #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/validator/routines/DomainValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,7 +1370,6 @@ private static class LazyHolder { // IODH
"xn--80asehdb", // онлайн CORE Association
"xn--80aswg", // сайт CORE Association
"xn--8y0a063a", // 联通 China United Network Communications Corporation Limited
"xn--90ae", // бг Imena.BG Plc (NAMES.BG Plc)
"xn--9dbq2a", // קום VeriSign Sarl
"xn--9et52u", // 时尚 RISE VICTORY LIMITED
"xn--9krt00a", // 微博 Sina Corporation
Expand Down Expand Up @@ -1725,6 +1724,7 @@ private static class LazyHolder { // IODH
"xn--54b7fta0cc", // বাংলা Posts and Telecommunications Division
"xn--80ao21a", // қаз Association of IT Companies of Kazakhstan
"xn--90a3ac", // срб Serbian National Internet Domain Registry (RNIDS)
"xn--90ae", // бг Imena.BG Plc (NAMES.BG Plc)
"xn--90ais", // ??? Reliable Software Inc.
"xn--clchc0ea0b2g2a9gcd", // சிங்கப்பூர் Singapore Network Information Centre (SGNIC) Pte Ltd
"xn--d1alf", // мкд Macedonian Academic Research Network Skopje
Expand Down
4 changes: 4 additions & 0 deletions src/test/java/org/apache/commons/validator/routines/DomainValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,10 @@ void testTopLevelDomains() {
assertTrue(validator.isValidCountryCodeTld(".uk"), ".uk should validate as ccTLD");
assertFalse(validator.isValidCountryCodeTld(".org"), ".org shouldn't validate as ccTLD");

// бг (xn--90ae) is the IDN ccTLD for Bulgaria, not a gTLD
assertTrue(validator.isValidCountryCodeTld("xn--90ae"), "xn--90ae (бг) should validate as ccTLD");
assertFalse(validator.isValidGenericTld("xn--90ae"), "xn--90ae (бг) shouldn't validate as gTLD");

// case-insensitive
assertTrue(validator.isValidTld(".COM"), ".COM should validate as TLD");
assertTrue(validator.isValidTld(".BiZ"), ".BiZ should validate as TLD");
Expand Down
Loading