CRYPTO-2: Create benchmark for Apache Commons Crypto#1
Open
winningsix wants to merge 1 commit intoapache:masterfrom
Open
CRYPTO-2: Create benchmark for Apache Commons Crypto#1winningsix wants to merge 1 commit intoapache:masterfrom
winningsix wants to merge 1 commit intoapache:masterfrom
Conversation
.gitignore
Outdated
| /lib/ | ||
| src/main/resources/com/intel/chimera/native/ | ||
| src/main/resources/com/intel/chimera/native/* No newline at end of file | ||
| src/main/resources/com/intel/chimera/native/* |
winningsix
force-pushed
the
benchmark
branch
2 times, most recently
from
13e14c1 to
6b10930
Compare
Rebase code update gitignore file Add script to support multi-JDK
| StreamOption streamOption) { | ||
| this.benchmarkOption = benchmarkOption; | ||
| this.streamOption = streamOption; | ||
| outputStream = new ByteArrayOutputStream(benchmarkOption.dataSize); |
Contributor
There was a problem hiding this comment.
It would be better add an little extra space in case that the output size is larger than the input size. 2 * 16 (block size) is enough I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes CRYPTO-2: Create benchmark for Apache Commons Crypto.