Add new Configuration called PrefixConfiguration#38
Open
nerdynick wants to merge 4 commits intoapache:masterfrom
Open
Add new Configuration called PrefixConfiguration#38nerdynick wants to merge 4 commits intoapache:masterfrom
nerdynick wants to merge 4 commits intoapache:masterfrom
Conversation
garydgregory
requested changes
Aug 20, 2020
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
Before I even ask you to write docs for the site's user guide [1], I think I'd like to see in this PR's description a better explanation of what need this PR fills, what problem does it solve, which you can then expand upon for the docs.
TY!
[1] https://commons.apache.org/proper/commons-configuration/userguide/user_guide.html
|
|
||
| import org.apache.commons.configuration2.convert.ListDelimiterHandler; | ||
|
|
||
| public class PrefixConfiguration extends AbstractConfiguration { |
| /** | ||
| * Add a configuration with a prefix. | ||
| * | ||
| * @param config the configuration to add |
Member
There was a problem hiding this comment.
Missing Javadoc @since tags on new methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new Configuration called PrefixConfiguration. It is similar to SubsetConfiguration, and barrows heavily from it. The difference is that it allows a user to apply a prefix to a given Configuration. It does this in the smilier view based manor that SubsetConfiguration does.