Skip to content

Conversation

@nvazquez
Copy link
Contributor

Description

This PR adds more comprehensive logs to the VM migration flow

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 11.42857% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (55ab7c5) to head (d57e3ac).
⚠️ Report is 17 commits behind head on 4.22.

Files with missing lines Patch % Lines
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 0.00% 21 Missing ⚠️
...resource/wrapper/LibvirtMigrateCommandWrapper.java 37.50% 5 Missing ⚠️
...pper/LibvirtPrepareForMigrationCommandWrapper.java 25.00% 3 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               4.22   #12332    +/-   ##
==========================================
  Coverage     17.59%   17.59%            
- Complexity    15595    15597     +2     
==========================================
  Files          5910     5910            
  Lines        529606   529718   +112     
  Branches      64705    64716    +11     
==========================================
+ Hits          93178    93206    +28     
- Misses       425940   426021    +81     
- Partials      10488    10491     +3     
Flag Coverage Δ
uitests 3.57% <ø> (+<0.01%) ⬆️
unittests 18.66% <11.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16147

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, just some nitpicking

Copy link
Collaborator

@abh1sar abh1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Co-authored-by: dahn <daan.hoogland@gmail.com>
@nvazquez
Copy link
Contributor Author

nvazquez commented Jan 8, 2026

@blueorangutan test

@nvazquez nvazquez added this to the 4.22.1 milestone Jan 8, 2026
@blueorangutan
Copy link

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland
Copy link
Contributor

I think we can settle for regression tests on this one.

@blueorangutan
Copy link

[SF] Trillian test result (tid-15138)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55790 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12332-t15138-kvm-ol8.zip
Smoke tests completed. 147 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 31.98 test_kubernetes_clusters.py
test_02_ssl_offloading_project_vpc Failure 288.60 test_ssl_offloading.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants