-
Notifications
You must be signed in to change notification settings - Fork 202
Run gp_internal_tools tests #1514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @andr-sokolov welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
leborchuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests ic_gpcontrib and ic_deb_gpcontrib are green.
LGTM
| "gpcontrib/gp_sparse_vector:installcheck", | ||
| "gpcontrib/gp_toolkit:installcheck"] | ||
| "gpcontrib/gp_toolkit:installcheck", | ||
| "gpcontrib/gp_internal_tools:installcheck"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any regression diffs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@my-ship-it Do you suggest to remove changes in this file, because the test is run from build-cloudberry.yml too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If any test failed, I think we can see the regression diffs in the ic-gpcontrib workflow, just like this:
be22ade to
76c3d77
Compare
|
Hi @andr-sokolov could you please resolve conflicts and rebase your PR? |
76c3d77 to
104b5d1
Compare
No description provided.