Skip to content

Conversation

@andr-sokolov
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @andr-sokolov welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!

@andr-sokolov andr-sokolov marked this pull request as ready for review December 30, 2025 08:12
Copy link
Contributor

@leborchuk leborchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ic_gpcontrib and ic_deb_gpcontrib are green.

LGTM

"gpcontrib/gp_sparse_vector:installcheck",
"gpcontrib/gp_toolkit:installcheck"]
"gpcontrib/gp_toolkit:installcheck",
"gpcontrib/gp_internal_tools:installcheck"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any regression diffs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@my-ship-it Do you suggest to remove changes in this file, because the test is run from build-cloudberry.yml too?

Copy link
Member

@tuhaihe tuhaihe Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any test failed, I think we can see the regression diffs in the ic-gpcontrib workflow, just like this:

@yjhjstz yjhjstz force-pushed the tests_gp_internal_tools branch from be22ade to 76c3d77 Compare January 23, 2026 21:49
@tuhaihe
Copy link
Member

tuhaihe commented Jan 27, 2026

Hi @andr-sokolov could you please resolve conflicts and rebase your PR?

@andr-sokolov andr-sokolov force-pushed the tests_gp_internal_tools branch from 76c3d77 to 104b5d1 Compare January 27, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants