fix(limit-req): use parent resource key for consumer isolation#13019
Draft
janiussyafiq wants to merge 3 commits intoapache:masterfrom
Draft
fix(limit-req): use parent resource key for consumer isolation#13019janiussyafiq wants to merge 3 commits intoapache:masterfrom
janiussyafiq wants to merge 3 commits intoapache:masterfrom
Conversation
f548452 to
ea10d8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, when limit-req was configured at the consumer level, rate limits were applied per route instead of globally per consumer. This occurred because the key generation concatenated
ctx.conf_typeandctx.conf_version, which included route-specific information. Now consumer-level rate limits are properly shared across all routes accessed by the same consumer by using theconf._meta.parentapproach.Changes:
Which issue(s) this PR fixes:
Fixes #12946
Checklist