cm: launcher: force balancing if any not scheduled instance on start detected#539
Open
mykola-kobets-epam wants to merge 2 commits intoaosedge:developfrom
Open
cm: launcher: force balancing if any not scheduled instance on start detected#539mykola-kobets-epam wants to merge 2 commits intoaosedge:developfrom
mykola-kobets-epam wants to merge 2 commits intoaosedge:developfrom
Conversation
Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
mlohvynenko
approved these changes
Mar 26, 2026
Member
mlohvynenko
left a comment
mlohvynenko
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
al1img
approved these changes
Mar 26, 2026
Collaborator
al1img
left a comment
al1img
left a comment
There was a problem hiding this comment.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
src/core/cm/launcher/instance.cpp
Outdated
| "runc", | ||
| }; | ||
|
|
||
| assert(mItemConfig); |
Collaborator
There was a problem hiding this comment.
Do not use assert, we will get rid of it soon. Better to return error.
…detected Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
mykola-kobets-epam
force-pushed
the
cm-launcher-integration
branch
from
a7185d9 to
7b49b59
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #539 +/- ##
===========================================
+ Coverage 85.31% 85.34% +0.03%
===========================================
Files 314 314
Lines 28083 28171 +88
Branches 3780 3790 +10
===========================================
+ Hits 23959 24043 +84
- Misses 4124 4128 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.