CM Database adaptation to launcher::StorageItf refactoring by mykola-kobets-epam · Pull Request #182 · aosedge/aos_core_cpp

mykola-kobets-epam · 2026-03-18T10:52:51Z

No description provided.

al1img · 2026-03-25T08:54:51Z

src/cm/database/tests/database.cpp

    launcher::InstanceStateEnum state = launcher::InstanceStateEnum::eCached, bool isUnitSubject = false,
    const char* version = "1.0.0", const char* ownerID = "owner1", SubjectTypeEnum subjectType = SubjectTypeEnum::eUser,
-    size_t priority = 0, std::vector<const char*> labels = {})
+    size_t priority = 0, std::vector<const char*> labels = {}, bool isSticky = false)


We renamed it to rebalancing disabled

al1img · 2026-03-25T08:55:17Z

src/cm/database/database.hpp

        eLabels,
-        ePriority
+        ePriority,
+        eIsSticky


MykolaSuperman

Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>

mlohvynenko · 2026-03-25T09:14:12Z

src/cm/database/tests/database.cpp

+    request.mLabels.Clear();
+
+    for (const char* label : labels) {
+        AOS_ERROR_CHECK_AND_THROW(request.mLabels.EmplaceBack(label), "can't add label");


I suggest using EmplaceBack + Back().Assign
Cause we can properly track if it's no mem in an Array or String capasity issue

mlohvynenko

Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>

codecov · 2026-03-25T11:23:44Z

Codecov Report

❌ Patch coverage is 98.26087% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@995ff45). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/cm/database/database.cpp	96.77%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             develop     #182   +/-   ##
==========================================
  Coverage           ?   82.42%           
==========================================
  Files              ?      325           
  Lines              ?    31130           
  Branches           ?     3214           
==========================================
  Hits               ?    25659           
  Misses             ?     5471           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

al1img

Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

al1img · 2026-03-25T12:19:38Z

src/cm/database/tests/database.cpp

    launcher::InstanceStateEnum state = launcher::InstanceStateEnum::eCached, bool isUnitSubject = false,
    const char* version = "1.0.0", const char* ownerID = "owner1", SubjectTypeEnum subjectType = SubjectTypeEnum::eUser,
-    size_t priority = 0, std::vector<const char*> labels = {})
+    size_t priority = 0, std::vector<const char*> labels = {}, bool disableRebalancing = false)


Update commit message

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>

sonarqubecloud · 2026-03-25T13:08:10Z

Quality Gate failed

Failed conditions
51.9% Coverage on New Code (required ≥ 80%)
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

al1img reviewed Mar 25, 2026

View reviewed changes

MykolaSuperman approved these changes Mar 25, 2026

View reviewed changes

mlohvynenko reviewed Mar 25, 2026

View reviewed changes

mlohvynenko approved these changes Mar 25, 2026

View reviewed changes

mykola-kobets-epam force-pushed the cm-launcher-0-comp-instances branch from 7193259 to 1c4e216 Compare March 25, 2026 10:54

al1img approved these changes Mar 25, 2026

View reviewed changes

mykola-kobets-epam added 3 commits March 25, 2026 14:22

cm: launcher: implement load/save run requests

aae965d

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com> Reviewed-by: Mykola Solianko <mykola_solianko@epam.com>

mykola-kobets-epam force-pushed the cm-launcher-0-comp-instances branch from 1c4e216 to 2560644 Compare March 25, 2026 12:22

mykola-kobets-epam changed the title ~~[WIP] CM Database adaptation to launcher::StorageItf refactoring~~ CM Database adaptation to launcher::StorageItf refactoring Mar 25, 2026

al1img merged commit e8cb676 into aosedge:develop Mar 25, 2026
9 of 10 checks passed

Conversation

mykola-kobets-epam commented Mar 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MykolaSuperman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mlohvynenko left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

al1img left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 25, 2026

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

codecov bot commented Mar 25, 2026 •

edited

Loading