Skip to content

fix(renderer): stabilize onResize ref to prevent rrp constraint race #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshitsinghbhandari wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −10
Open

fix(renderer): stabilize onResize ref to prevent rrp constraint race #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions frontend/src/renderer/components/SessionView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useRef, useState } from "react";
import { useCallback, useEffect, useRef, useState } from "react";
import { useNavigate } from "@tanstack/react-router";
import type { PanelImperativeHandle, PanelSize } from "react-resizable-panels";
import { CenterPane } from "./CenterPane";
Expand Down Expand Up @@ -96,15 +96,22 @@ export function SessionView({ sessionId, projectId }: SessionViewProps) {

// Persist drags and mirror collapse state (dragging past minSize collapses)
// back into the store. Read the store imperatively to avoid a stale closure.
const handleInspectorResize = (size: PanelSize) => {
const open = useUiStore.getState().isInspectorOpen;
if (size.asPercentage > 0) {
window.localStorage?.setItem(inspectorSplitStorageKey, String(size.asPercentage));
if (!open) toggleInspector();
} else if (open) {
toggleInspector();
}
};
// Wrapped in useCallback so rrp v4's panel registration useLayoutEffect (which
// includes onResize in its dep array) does not de-register/re-register the
// inspector panel on every render — preventing the "Panel constraints not found
// for Panel inspector" race with the expand()/collapse() effect above.
const handleInspectorResize = useCallback(
(size: PanelSize) => {
const open = useUiStore.getState().isInspectorOpen;
if (size.asPercentage > 0) {
window.localStorage?.setItem(inspectorSplitStorageKey, String(size.asPercentage));
if (!open) toggleInspector();
} else if (open) {
toggleInspector();
}
},
[toggleInspector],
);

if (!session && !workspaceQuery.isLoading) {
return (
Expand Down
Loading