fix(ui): permission mode select + remove notification stub#190
Merged
Conversation
- Replace free-text AgentConfig.permissions field with a Select showing the four valid modes (default, accept-edits, auto, bypass-permissions) so users can't enter invalid strings (#186). - Delete the non-functional Notifications bell button from Topbar and DashboardTopbar; remove the now-unused Bell import (#188). Closes #186 Closes #188 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
harshitsinghbhandari has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PermissionModeSelectcomponent toProjectSettingsFormwith the four valid options (default,accept-edits,auto,bypass-permissions). Previously theagentConfig.permissionsfield was not surfaced in the UI; this adds it as a proper enum select so users can't type invalid strings, and exposes it in the Save payload.TopbarandDashboardTopbar, and removes the now-unusedBelllucide import from both files.Test plan
pnpm tsc --noEmit— no type errors.Closes #186
Closes #188