fix(session-manager): deliver orchestrator instructions via system prompt#189
Merged
Merged
Conversation
…ompt Orchestrator role definitions and worker coordination hints were being prepended/appended to the user-facing prompt string. They now go into SystemPrompt in LaunchConfig so agents receive them as standing instructions rather than part of the human's task request. Closes #182 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
harshitsinghbhandari has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promptstring, conflating standing instructions with the human's task request.LaunchConfig.SystemPromptso agents receive them as persistent behavioral context via--append-system-prompt, not as part of the conversational turn.Metadata.Promptnow stores only the user's actual task prompt, which is correct for session restore.appendPromptSectionhelper is removed.Closes #182
Test plan
TestSpawnOrchestrator_UsesCoordinatorPrompt— verifies coordinator instructions appear inSystemPrompt, notPromptTestSpawnWorker_AppendsActiveOrchestratorContact— verifies coordination hint is inSystemPrompt; user prompt stored as-is in metadataTestSpawnWorker_SkipsTerminatedOrchestratorContact— verifies no coordination hint for terminated orchestratorsgo test -race ./...— 1264 tests pass🤖 Generated with Claude Code