Feature/custom user styles#80
Open
Pjb518 wants to merge 18 commits into
Open
Conversation
Collaborator
Author
|
Should also mention that some of the type are not happy right now and I haven't got around to appeasing them 😄 |
…meConfig class for the new settings menu. Adds a new template for the custom theme app.
…ckground colour SCSS variable which links to a new custom property. Makes use of transparent in the headline linear gradients to better enable theming. Updates all uses of the sheet-background SCSS variable with the new fatex-sheet-background-color variable.
…affected. Removes a selector targeting the chat text area. Adds a new selector to target the chat header line. Adds a new SCSS variable for the scrollbar pill colour.
…ents which currently have CSS custom properties.
…class. Temporarily disables type checking on the ThemeConfiguration file. Updates the theme-config template to use initial values provided by the ThemeConfig class. Adds currently non-functional buttons for saving a theme, reverting to the default, and closing without making changes.
…at they can be easily referenced. Updates the getData method in the ThemeConfiguration, allowing it to set the current values for the colour pickers to the values of defined custom properties. If the custom properties are not set, the system falls back to the default styles defined in the global config.
… css Custom Property. Will be revisiting this, as I don't like that custom properties are defined in three places. Implements the activateListeners method on the ThemeConfig class. Adds an onChange method to update custom properties in real time as the user selects new colours. These changes currently do not persist after reload.
…er the user's updates should be saved. Implements the _updateObject method on the ThemeConfig class to store the user's colour settings as user flags. Adds listeners for the remaining buttons for the theme config app.
…e custom properties are still missing. There is currently a bug where sometimes one or two of the flags are not remembering their new values after reload. This causes old styles to resurface, and I haven't yet found the cause.
…stored in the global config, simplifying the way data is access in the ThemeConfig class. This should also be more robust as we no longer rely on indices.
PatrickBauer
force-pushed
the
feature/custom-user-styles
branch
from
7fabced to
6ecdb06
Compare
…configuration settings.
…onfig window slightly wider. Adds an explanation for the main shadow setting.
…plementation similar to the TemplateActorsFeature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability for users to select custom colour schemes for the FateX interface. This is still a WIP, but it is mostly functional at the moment.
There are three known issues:
I haven't yet added the full array of custom properties that users will be able to choose from. They currently have no control over much of the interface text colour, for example.
There is a strange bug where user flags forget that they have been updated after reloading the game. Viewing the user flags in game shows that the values have been updated, but when the game is reloaded, sometimes one or two pieces of the interface show old colour choices, and the user flags seem to have reverted to their old values.
I'm not sure if this is a Foundry bug, but DSN doesn't seem to have this problem, so maybe I'm overlooking a simple mistake.
I'm not happy with the way that default values and custom properties are being stored in the config. Now that the feature is actually working, I'd like to go back and make the data easier to work with.