security(supervisor): re-enable release tag signature verification#39
Open
DeryFerd wants to merge 1 commit into
Open
security(supervisor): re-enable release tag signature verification#39DeryFerd wants to merge 1 commit into
DeryFerd wants to merge 1 commit into
Conversation
Restore verify_tag during non-nightly updates unless skip_verify is set. CLI --force continues to bypass verification for local development. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release updates were skipping tag signature checks entirely. In
supervisor/supervisor.py, step 2 ofrun_update()had verification gated behindif False, so every non-nightly update continued even whengit verify-tagwould have failed.This PR turns that check back on for normal tagged releases. When
skip_verifyis false (the default), the supervisor callsverify_tag()and aborts the update withUpdateErrorif GPG/SSH verification fails.Intentional bypass paths stay the same:
skip_verify=Truestill skips it — this is whatevonic update --forceuses for local/dev installs without signed tags.Plugin zip signing (separate PR) covers install-time artifacts; this change is specifically about release tags fetched during
evonic update.What changed
supervisor/supervisor.py: restoreif not skip_verify:aroundverify_tag(); clearer log/notify text when verification runs vs when--forceskips it.unit_tests/test_supervisor/test_lifecycle.py: happy path now expectsverify_tagto run; added coverage forskip_verify=True.Risk / compatibility
originwill see updates fail until tags are signed or the operator uses--force. That matches the intended supply-chain posture for tagged releases.--forcebehavior.Validation
python -m pytest unit_tests/test_supervisor/ -qevonic updateagainst a live signed tag (would need a staged install with GPG/SSH trust configured).