Hello! Here is my branch for challenge_1, enjoy#7
Open
jjsaund wants to merge 2 commits intoantsh3k:mainfrom
Open
Hello! Here is my branch for challenge_1, enjoy#7jjsaund wants to merge 2 commits intoantsh3k:mainfrom
jjsaund wants to merge 2 commits intoantsh3k:mainfrom
Conversation
Owner
|
Very elegant solution. Well done. The wrapping paper is on order: A couple minor comments:
|
antsh3k
reviewed
Dec 16, 2024
|
|
||
| data['result'] = data.apply(lambda row: total_material(row['Length'], row['Width'], row['Height']), axis=1) | ||
|
|
||
| print(f"Total wrappping material needed: {data.result.sum()}") |
antsh3k
reviewed
Dec 16, 2024
| def total_material(L,W,H): | ||
| sa = 2*(L*W+W*H+H*L) | ||
| sorted_dims = sorted([L, W, H]) | ||
| min = sorted_dims[0] |
Owner
There was a problem hiding this comment.
Avoid using built-in names like min, max for variable names.
antsh3k
requested changes
Dec 16, 2024
Owner
antsh3k
left a comment
antsh3k
left a comment
There was a problem hiding this comment.
The logic and solution is great. Please address the specified minor chnages before I will accept the PR.
Owner
There was a problem hiding this comment.
This should not be tracked via git. Create a .gitignore file and add *.csv to the contents. this will stop tracking the data file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope this works!
BW
Jasjot