Skip to content

Don't #[allow(type_alias_bounds)].#1

Closed
eddyb wants to merge 8 commits intoantoyo:masterfrom
eddyb:patch-1
Closed

Don't #[allow(type_alias_bounds)].#1
eddyb wants to merge 8 commits intoantoyo:masterfrom
eddyb:patch-1

Conversation

@eddyb
Copy link
Copy Markdown

@eddyb eddyb commented Sep 18, 2018

rust-lang/rust#54090 will fix false positives (maybe relevant?) and make it an error in the upcoming Rust 2018 edition, which means that if you want to migrate to Rust 2018, it shouldn't be ignored.

See also rust-lang/rust#49441 (comment) for the decision and some background.

@antoyo antoyo force-pushed the master branch 2 times, most recently from 44a1bb5 to 45e964e Compare May 30, 2019 11:42
@antoyo antoyo closed this Jul 12, 2019
@eddyb
Copy link
Copy Markdown
Author

eddyb commented Jul 12, 2019

I'm confused, what happened here?
Sadly, the type alias changes didn't make it into Rust 2018 but they should probably be revived at some point.

@antoyo
Copy link
Copy Markdown
Owner

antoyo commented Jul 12, 2019

Actually, I completely forgot about this PR. Sorry about that.
I'm not even sure why it was closed (maybe because I force pushed).
I guess I'll fix it when it becomes an error.

@eddyb
Copy link
Copy Markdown
Author

eddyb commented Jul 12, 2019

It won't be an error in this case, I think it's a false positive warning right now, so the warning would just go away. For the record, this was the entire diff:

diff --git a/tiger/src/gen.rs b/tiger/src/gen.rs
index e3793be..56b2516 100644
--- a/tiger/src/gen.rs
+++ b/tiger/src/gen.rs
@@ -57,7 +57,6 @@ use ir::Statement::{
 };
 use temp::{Label, Temp};
 
-#[allow(type_alias_bounds)]
 pub type Access<F: Frame> = (Level<F>, F::Access);
 
 #[derive(Clone)]

@eddyb
Copy link
Copy Markdown
Author

eddyb commented Jul 12, 2019

I just tried to push an updated version and GitHub won't let me reuse this PR.
Oh well, the diff is trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants