Don't #[allow(type_alias_bounds)].#1
Closed
eddyb wants to merge 8 commits intoantoyo:masterfrom
Closed
Conversation
44a1bb5 to
45e964e
Compare
Author
|
I'm confused, what happened here? |
Owner
|
Actually, I completely forgot about this PR. Sorry about that. |
Author
|
It won't be an error in this case, I think it's a false positive warning right now, so the warning would just go away. For the record, this was the entire diff: diff --git a/tiger/src/gen.rs b/tiger/src/gen.rs
index e3793be..56b2516 100644
--- a/tiger/src/gen.rs
+++ b/tiger/src/gen.rs
@@ -57,7 +57,6 @@ use ir::Statement::{
};
use temp::{Label, Temp};
-#[allow(type_alias_bounds)]
pub type Access<F: Frame> = (Level<F>, F::Access);
#[derive(Clone)] |
Author
|
I just tried to push an updated version and GitHub won't let me reuse this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#54090 will fix false positives (maybe relevant?) and make it an error in the upcoming Rust 2018 edition, which means that if you want to migrate to Rust 2018, it shouldn't be ignored.
See also rust-lang/rust#49441 (comment) for the decision and some background.