Modification when MODID list is Empty#4
Open
GuberX wants to merge 2 commits into
Open
Conversation
Fixing check Mods ID when mod list is empty
Fix the Mod ID check for empty Mod IDs in Servergrid.json
Owner
|
This should have been solved with 73fb125. Let me know if it persists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into error loop when my modID list was empty in my servergrid.json. this adjustment will fix that issue, will check first then proceed to the next action.
I have ran my adjusted code, and uploaded it to the atlasmap-js folder on my webserver. and it all works just as intended.
If you are okay with the adjustments, fill free to merge/update the files(not fully sure how this works, my first contribution on github)