[codex] Add runtime string format opt-ins#30
Merged
Conversation
anthonyprintup
force-pushed
the
codex/runtime-string-format-opt-ins
branch
2 times, most recently
from
0da32ea to
dcab33f
Compare
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcab33ff9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anthonyprintup
force-pushed
the
codex/runtime-string-format-opt-ins
branch
from
dcab33f to
7638498
Compare
Add PROTOCYTE_ENABLE_STD_FORMAT for std::formatter support on protocyte::String<Config>. Add PROTOCYTE_ENABLE_FMT_FORMAT for ADL format_as support without introducing a fmt dependency. Regenerate the smoke runtime header and add direct std::format smoke coverage for runtime strings, width formatting, and embedded NUL preservation.
anthonyprintup
force-pushed
the
codex/runtime-string-format-opt-ins
branch
from
7638498 to
62b6965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROTOCYTE_ENABLE_STD_FORMATto enablestd::formattersupport forprotocyte::String<Config>.PROTOCYTE_ENABLE_FMT_FORMATto enable ADLformat_assupport for{fmt}without adding a hard fmt dependency.std::formatsmoke coverage for runtime strings, width formatting, and embedded NUL preservation.Test Plan
uv run python -m compileall src testsuv run pytest -qcmake --build build\clangcl --target protocyte_host_smokectest --test-dir build\clangcl --output-on-failuregit diff --check