[codex] Add smoke marshalling benchmarks#28
Merged
Conversation
Add opt-in Google Benchmark targets for Protocyte and protobuf marshalling comparisons. Extract the shared UltimateComplexMessage smoke fixture so tests and benchmarks populate the same message shape, and add a protobuf-only benchmark schema without Protocyte extensions. Wire benchmark CMake presets and generated protobuf code into the smoke build.
Ensure the protobuf comparison benchmark has a libprotobuf target even when codegen initially resolves to a standalone protoc executable. Fall back to finding or fetching protobuf for the benchmark runtime, and use the fetched protoc when protobuf is fetched so generated code matches the linked library.
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
clang-formaton touched C++ filescmake --build smoke\build\clangcl --target protocyte_host_smokecmake --build smoke\build\clangcl-benchmarks --target protocyte_host_benchmark protocyte_host_protobuf_benchmarkctest --test-dir smoke\build\clangcl --output-on-failure(25/25 passed)protocyte_host_benchmarkandprotocyte_host_protobuf_benchmarkprotocyte_host_protobuf_benchmarkgit diff --check