Skip to content

[codex] Add smoke marshalling benchmarks#28

Merged
anthonyprintup merged 2 commits into
mainfrom
codex/protobuf-benchmark
May 1, 2026
Merged

[codex] Add smoke marshalling benchmarks#28
anthonyprintup merged 2 commits into
mainfrom
codex/protobuf-benchmark

Conversation

@anthonyprintup
Copy link
Copy Markdown
Owner

Summary

  • add opt-in Google Benchmark smoke targets for Protocyte marshalling and protobuf comparison
  • extract shared UltimateComplexMessage fixture setup for smoke tests and benchmarks
  • generate a protobuf-only benchmark schema without Protocyte extensions
  • ensure the protobuf benchmark fetches a linkable protobuf runtime when only standalone protoc is available

Validation

  • clang-format on touched C++ files
  • cmake --build smoke\build\clangcl --target protocyte_host_smoke
  • cmake --build smoke\build\clangcl-benchmarks --target protocyte_host_benchmark protocyte_host_protobuf_benchmark
  • ctest --test-dir smoke\build\clangcl --output-on-failure (25/25 passed)
  • short smoke runs for protocyte_host_benchmark and protocyte_host_protobuf_benchmark
  • reproduced the protoc-only benchmark configure case and verified the fallback fetch path now configures and builds protocyte_host_protobuf_benchmark
  • git diff --check

Add opt-in Google Benchmark targets for Protocyte and protobuf marshalling comparisons. Extract the shared UltimateComplexMessage smoke fixture so tests and benchmarks populate the same message shape, and add a protobuf-only benchmark schema without Protocyte extensions. Wire benchmark CMake presets and generated protobuf code into the smoke build.
Ensure the protobuf comparison benchmark has a libprotobuf target even when codegen initially resolves to a standalone protoc executable. Fall back to finding or fetching protobuf for the benchmark runtime, and use the fetched protoc when protobuf is fetched so generated code matches the linked library.
@anthonyprintup
Copy link
Copy Markdown
Owner Author

@codex review

@anthonyprintup anthonyprintup marked this pull request as ready for review May 1, 2026 17:29
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anthonyprintup anthonyprintup merged commit ecb5fbd into main May 1, 2026
8 checks passed
@anthonyprintup anthonyprintup deleted the codex/protobuf-benchmark branch May 1, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant