Generate and parse image timestamps#155
Draft
astarivi wants to merge 3 commits into
Draft
Conversation
# Conflicts: # xdvdfs-core/src/write/img.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #37 by introducing an implementation-agnostic
FileTimestruct at thecoremodule, allowing downstream to implement their own time gen and parsing mechanisms.To implement this new time structure into the image write logic, a new function
create_xdvdfs_image_with_filetimehas been created, which takes theFileTimestruct as an argument.create_xdvdfs_imageis still available, and will default to a 0 timestamp value.Implementation details:
xdvdfs-clichronocrate to generate and parse dates.timestamp (-t)andtimestamp_now (-T)topackandcompresssub-commands. These default to a 0 timestamp value if no flag is given (see Make thepackcommand produce a predictable image file from the same content source. #101)infosub-command will now print the parsed (RFC 3339), and the Unix equivalent of the image timestamp.exiso_compatis excluded from this implementation.build_imageis excluded from this implementation (timestamp should be a part of the spec file?)