Force re-computation with event stream bulk create#1578
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe ChangesRBAC cache maintenance in test fixture
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1578 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 244 244
Lines 11214 11214
=======================================
Hits 10353 10353
Misses 861 861
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Assisted-By: claude sonet
8a9b0c9 to
f26d37a
Compare
|



Hit a failure in
ansible/django-ansible-base#970
And I can explain what's happening, and why it's basically passing accidentally now.
DAB RBAC is a signals-based library. If you
bulk_createobjects, organization permissions will not be properly rebuilt, this is expected. The fixture involved does exactly this, and the test expects that lists show event streams correctly.This happens to work now, because later on in the process, a credential is created. The signals that fire due to the credential creation happen to re-build role evaluations related to the previously-created event stream objects. This is because the signals are overly-broad. The DAB PR 970 narrows the scope of what those signals touch, which is a good thing, but incompatible with how this test was functioning.
Confirmed locally, after applying this change, the failing tests pass even with the DAB patch.
Summary by CodeRabbit