add async support to all non-deprecated filters by dvayanu · Pull Request #293 · anotheria/moskito

dvayanu · 2026-06-19T11:38:57Z

Summary

Added <async-supported>true</async-supported> to all filter declarations in moskito-web/src/main/resources/META-INF/web-fragment.xml — the primary fix for apps that embed the JAR via web-fragment auto-registration
Added @WebFilter(asyncSupported = true) to all active (non-deprecated) filter classes for annotation-scanning / @ServletComponentScan deployments
Added registrationBean.setAsyncSupported(true) to every FilterRegistrationBean in both moskito-springboot and moskito-springboot2 auto-configurations
Deprecated filters (DomainFilter, MethodFilter, RefererFilter, RequestURIFilter, UserAgentFilter) intentionally excluded

Without these changes, any filter in the chain that does not declare async support causes the servlet container to throw an IllegalStateException when a downstream endpoint (e.g. SSE/MCP) calls request.startAsync().

Test plan

Deploy an app using the moskito-web JAR and verify an SSE or async endpoint passes through the filter chain without IllegalStateException
Verify Spring Boot auto-configuration registers filters with asyncSupported = true
Confirm existing synchronous request monitoring still works correctly

🤖 Generated with Claude Code

Bumps [spring-web](https://github.com/spring-projects/spring-framework) from 4.2.5.RELEASE to 6.0.0. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v4.2.5.RELEASE...v6.0.0) --- updated-dependencies: - dependency-name: org.springframework:spring-web dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [spring-web](https://github.com/spring-projects/spring-framework) from 5.3.14 to 6.0.0. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v5.3.14...v6.0.0) --- updated-dependencies: - dependency-name: org.springframework:spring-web dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

… they are not invoked on the server side

# Conflicts: # moskito-core/pom.xml # moskito-webui/pom.xml

# Conflicts: # moskito-aop/pom.xml # moskito-core/pom.xml # moskito-extensions/moskito-additional-producers/pom.xml # moskito-extensions/moskito-disk-space-monitoring/pom.xml # moskito-extensions/moskito-mongodb/pom.xml # moskito-extensions/moskito-monitoring-plugin/pom.xml # moskito-extensions/moskito-notification-providers/pom.xml # moskito-extensions/moskito-php/pom.xml # moskito-extensions/moskito-saas/pom.xml # moskito-extensions/moskito-sampling-api/pom.xml # moskito-extensions/pom.xml # moskito-inspect-standalone/pom.xml # moskito-integration/moskito-cdi/pom.xml # moskito-integration/moskito-ehcache/pom.xml # moskito-integration/moskito-inspect-embedded/pom.xml # moskito-integration/moskito-inspect-jersey/pom.xml # moskito-integration/moskito-inspect-remote/pom.xml # moskito-integration/moskito-springboot/pom.xml # moskito-integration/moskito-springboot2/pom.xml # moskito-integration/moskito-sql/pom.xml # moskito-integration/pom.xml # moskito-web/pom.xml # moskito-webui/pom.xml # pom.xml

EntityCounter

Utility to monitor collection sizes

Issue #275: Utility to monitor collection sizes

Replaced Maven Central badge with MvnRepository badge.

…ot alerts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…lert #30 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ng alert #59 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…rary noise Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…t alerts #28 #29 Closes #291 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

ano-util 4.0.0→4.0.4, commons-codec 1.16.0→1.22.0, gson 2.10.1→2.14.0, logback-classic 1.5.21→1.5.33, mockito-core 5.6.0→5.23.0, aspectj 1.9.20→1.9.25.1, aspectj-maven-plugin 1.14.0→1.16.0, maven-pmd-plugin 3.22.0→3.28.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@webfilter

Enables async servlet support across all active MoSKito filters so they do not block async dispatch chains (e.g. SSE/MCP endpoints). Three deployment paths are covered: web-fragment.xml (<async-supported>true), @webfilter(asyncSupported=true) on each filter class, and FilterRegistrationBean.setAsyncSupported(true) in the Spring Boot 1/2 auto-configurations. Deprecated filters are intentionally excluded. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-advanced-security · 2026-06-19T11:39:21Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

dvayanu · 2026-06-19T11:41:15Z

Closing — wrong base branch. Re-opening as a feature branch PR targeting develop.

dependabot Bot and others added 30 commits December 10, 2022 02:22

Javax -> Jakarta(EE 9) migration

4cddd48

Dependency version update.

c9d5630

ano-parent version update

171db23

moskito-webui jstl update

5bf5808

moskito-webui jstl update

39db280

ano-parent update

aef59b2

#271 moved references to HttpServletRequest out of PO object, so that…

88dae54

… they are not invoked on the server side

[maven-release-plugin] prepare release moskito-3.2.7

2b5bac9

[maven-release-plugin] prepare for next development iteration

542f95a

migrate to java 11

7466b81

https://github.com/anotheria/moskito/issues/272

bad8d0d

Merge remote-tracking branch 'origin/java-11' into develop.4x

dde9144

# Conflicts: # moskito-core/pom.xml # moskito-webui/pom.xml

migrate to java 11

319c451

migrate to java 11

87ff364

Create pmd.yml

d68b4f8

renamed file

c06ca67

https://github.com/anotheria/moskito/issues/273

08fd682

MAT-9965: EntityCounter

cad166c

Merge pull request #276 from anotheria/monitor-collection

9f723b5

EntityCounter

Issue #275: Utility to monitor collection sizes

82c9c39

Issue #275: Utility to monitor collection sizes

d90238d

Issue #275: Utility to monitor collection sizes

9508d58

Issue #275: Utility to monitor collection sizes

ff20ec0

Merge pull request #277 from anotheria/counter

fb5715c

Utility to monitor collection sizes

Issue #275: Utility to monitor collection sizes

b3b205c

Merge pull request #278 from anotheria/counter

cfcae05

Issue #275: Utility to monitor collection sizes

Issue #275: Utility to monitor collection sizes

9b1f786

dvayanu and others added 27 commits November 17, 2025 20:49

added claude to gitignore

98c52ea

Resource fix leak

82c3631

minor improvements in style

ac49e67

replaced deprecated reflection API

b1ba602

stylistic fixes

ddebc65

updated document

aa85308

fixes

f5b2555

changed parent version to non-snapshot

653faa5

[maven-release-plugin] prepare release moskito-4.0.5

2109fe3

[maven-release-plugin] prepare for next development iteration

3b6a256

fixed name

b2db142

[maven-release-plugin] prepare release moskito-4.0.6

86614d3

[maven-release-plugin] prepare for next development iteration

63ba3d1

Update badge in README for MvnRepository

758fcfd

Replaced Maven Central badge with MvnRepository badge.

bump log4j-core to 2.25.4 and commons-lang3 to 3.18.0 to fix Dependab…

4f715d7

…ot alerts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

bump spring-boot to 3.3.11 in moskito-springboot2 to fix Dependabot a…

8b6ba40

…lert #30 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix XSS-through-DOM in JSP delete handlers by encoding data attributes

12e6a15

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

add explicit read-only permissions to PMD workflow to fix code scanni…

c9dd3fa

…ng alert #59 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

exclude vendored JS from CodeQL analysis to eliminate third-party lib…

36e3390

…rary noise Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

bump spring-web to 6.0.23 in both springboot modules, fixes Dependabo…

ffb5f07

…t alerts #28 #29 Closes #291 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

[maven-release-plugin] prepare release moskito-4.0.7

d39f34f

[maven-release-plugin] prepare for next development iteration

dac0066

updated ano-tags dependency

1e9fa4f

[maven-release-plugin] prepare release moskito-4.0.8

0c8588d

[maven-release-plugin] prepare for next development iteration

582b695

dvayanu closed this Jun 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add async support to all non-deprecated filters#293

add async support to all non-deprecated filters#293
dvayanu wants to merge 123 commits into
masterfrom
develop

dvayanu commented Jun 19, 2026

Uh oh!

github-advanced-security AI commented Jun 19, 2026

Uh oh!

dvayanu commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

dvayanu commented Jun 19, 2026

Summary

Test plan

Uh oh!

github-advanced-security AI commented Jun 19, 2026

What Enabling Code Scanning Means:

Uh oh!

dvayanu commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants