Skip to content

Add support for existing VNets to the dcos-one-master template.#1

Open
brendandburns wants to merge 1 commit into
anhowe:masterfrom
brendandburns:master
Open

Add support for existing VNets to the dcos-one-master template.#1
brendandburns wants to merge 1 commit into
anhowe:masterfrom
brendandburns:master

Conversation

@brendandburns

Copy link
Copy Markdown

This splits the vnet config out into an optional component.

},
"linuxVersion": {
"defaultValue": "16.04.201605161",
"defaultValue": "latest",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pin to a specific version because of words introduced upstream that caused an outage.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, s/words/errors (code review on a phone is a bad idea)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version (16.04.201605161) is missing so the template doesn't currently work. I think we need a better story for ensuring that the templates in github work. How do we choose/validate what image to use currently? We need some sort of automated testing here.

@yoannchaudet yoannchaudet Aug 23, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran into the same same issue while playing with this template. The version is actually available but under another SKU. Try replacing 16.04.0-DAILY-LTS by 16.04.0-LTS.

@brendandburns

Copy link
Copy Markdown
Author

Comments addressed, please re-check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants