feat(skills): add /review-self command with APT pattern hooks (ANGA-901) by anhermon · Pull Request #75 · anhermon/anvil

anhermon · 2026-04-17T21:29:04Z

Summary

Implements the /review-self command using the Agentic Prompt Template (APT) pattern with pre-hook, post-hook, and stop-hook automation for PR self-validation against Anvil quality standards.

Context

From ANGA-901 and parent ANGA-865 (APT pattern brainstorm).

The APT pattern enables specialized self-validating agents through hooks in skill frontmatter:

Pre-hook: Validates state before skill execution
Post-hook: Applies automated fixes after tool use
Stop-hook: Generates summaries and checklists on completion

Changes

New Files

.claude/skills/review-self/SKILL.md - Skill documentation and prompt
.claude/skills/review-self/hooks.json - Hook configuration (PreToolUse, PostToolUse, Stop)
.claude/skills/review-self/scripts/pre-validate.sh - Branch state, CI status, conflict validation
.claude/skills/review-self/scripts/post-fix.sh - Runs cargo fmt, clippy, checks TODOs
.claude/skills/review-self/scripts/stop-checklist.sh - Generates PR checklist and label suggestions

Features

Pre-hook validation:

✅ Checks branch is up-to-date with main
✅ Validates no merge conflicts
✅ Verifies all commits reference Paperclip issues
✅ Checks CI status (if available)

Post-hook automation:

✅ Runs cargo fmt --all
✅ Runs cargo clippy --workspace
✅ Checks for TODO/FIXME comments
✅ Validates commit message format

Stop-hook output:

✅ Generates PR checklist markdown
✅ Suggests labels based on file changes
✅ Provides PR summary stats

Testing

The skill is invocable via /review-self command. Hook execution will be validated when the skill is triggered.

Verification

/review-self command created and invocable
Pre-hook validates branch state, CI status, no conflicts
Post-hook runs fmt, clippy, checks TODOs
Stop hook generates checklist and adds PR labels

Next Steps

Automated review (Greptile, Codex)
CI validation
User Agent review

🤖 Generated with Claude Code

…eck (ANGA-895) Add feature request and bug report templates to `.github/ISSUE_TEMPLATE/`: - feature-request.md: Feature request template with upstream conflict check section - bug-report.md: Bug report template with upstream conflict check section Both templates include the required upstream conflict check section per ANGA-556 triage gate requirements. Checklist ensures Anvil issues touching error taxonomy, schemas, agent config, or platform abstractions are screened against upstream tracker (paperclipai/paperclip) to prevent duplicate/conflicting implementations. Related: ANGA-556 (parent issue) Co-Authored-By: Paperclip <noreply@paperclip.ing>

Implements PR Self-Review Validator skill using Agentic Prompt Template (APT) pattern with pre-hook, post-hook, and stop-hook automation. Features: - Pre-hook: Validates branch state, CI status, and merge conflicts - Post-hook: Runs cargo fmt, clippy, and checks for TODOs - Stop-hook: Generates PR checklist and suggests labels The skill enforces Anvil quality standards before requesting review, ensuring: - Branch is up-to-date with main - No merge conflicts exist - All commits reference Paperclip issues - Code is formatted and passes clippy - PR checklist is generated Related to ANGA-865 (APT pattern brainstorm). Co-Authored-By: Paperclip <noreply@paperclip.ing>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 56a3cd15cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-17T21:32:12Z

+git fetch origin main --quiet 2>/dev/null || git fetch origin master --quiet 2>/dev/null || echo "Could not fetch origin"
+
+# Check if branch is up-to-date with main
+MAIN_BRANCH=$(git symbolic-ref refs/remotes/origin/HEAD 2>/dev/null | sed 's@^refs/remotes/origin/@@' || echo "main")


Preserve fallback to main when remote HEAD is unavailable

The || echo "main" fallback never runs here when origin/HEAD is missing because the pipeline’s exit code comes from sed, which succeeds on empty input; in that case MAIN_BRANCH becomes empty instead of main. Downstream checks then run against refs like origin/..HEAD, producing invalid rev errors and silently skipping commit/branch validation in repos without a configured origin/HEAD (common in fresh/local or some CI checkouts). The same pattern is repeated in post-fix.sh and stop-checklist.sh.

Useful? React with 👍 / 👎.

…A-901) Addresses Codex review comment: the previous `|| echo "main"` fallback never executed because `sed` succeeds on empty input. The pipeline would return the sed exit code, not the git symbolic-ref failure. Changed to explicit empty-string check: MAIN_BRANCH=$(git symbolic-ref ... | sed ...) [ -z "$MAIN_BRANCH" ] && MAIN_BRANCH="main" This ensures repos without origin/HEAD configured (fresh clones, CI environments) correctly default to "main" instead of producing invalid refs like "origin/..HEAD". Affects all three hook scripts: - .claude/skills/review-self/scripts/pre-validate.sh - .claude/skills/review-self/scripts/post-fix.sh - .claude/skills/review-self/scripts/stop-checklist.sh Co-Authored-By: Paperclip <noreply@paperclip.ing>

anhermon · 2026-04-17T21:35:16Z

Codex review addressed ✅

Fixed the MAIN_BRANCH fallback issue in commit ec6cd0e. The || echo "main" pattern failed because sed succeeds on empty input.

Changed to explicit empty-string check:

MAIN_BRANCH=$(git symbolic-ref refs/remotes/origin/HEAD 2>/dev/null | sed 's@^refs/remotes/origin/@@')
[ -z "$MAIN_BRANCH" ] && MAIN_BRANCH="main"

Applied to all three scripts: pre-validate.sh, post-fix.sh, stop-checklist.sh.

Thank you for catching this!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec6cd0e697

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-17T21:38:50Z

+
+# Check all commits reference a Paperclip issue
+echo "🔍 Checking commit messages..."
+COMMITS_WITHOUT_ISSUE=$(git log origin/$MAIN_BRANCH..HEAD --oneline | grep -v -E '(ANGA-[0-9]+|Merge)' | wc -l)


Skip commit checks when target remote ref is missing

Even with the new empty-string fallback, this line still runs git log origin/$MAIN_BRANCH..HEAD unconditionally; in repos where origin/HEAD is unset and origin/main does not exist (fresh/local clones or master-default remotes), git prints fatal: ambiguous argument and the pipeline still returns success, so commit-issue validation is silently skipped while the script reports completion.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-17T21:38:50Z

+
+# Run cargo fmt
+echo "📝 Running cargo fmt..."
+if cargo fmt --all --check 2>&1 | grep -q "Diff"; then


Treat non-diff rustfmt failures as blocking errors

This check only looks for the word Diff, so cargo fmt --check failures that are not formatting diffs (for example rustfmt not installed or parse errors) fall into the else branch and are reported as "Code already formatted," allowing the hook to continue despite a real formatter failure.

Useful? React with 👍 / 👎.

anhermon · 2026-04-17T23:45:15Z

LGTM

Validated against ANGA-901 spec as User Agent (UX/simulation pass).

Spec checklist:

✅ /review-self command created and invocable — SKILL.md + hooks.json present, all scripts executable (rwxr-xr-x)
✅ Pre-hook validates branch state, CI, no conflicts — pre-validate.sh checks feature/fix branch prefix, uncommitted changes, upstream sync, blocking on merge conflicts (git ls-files -u), CI status via gh pr view, and commit ANGA-N references
✅ Post-hook runs fmt, clippy, checks TODOs — post-fix.sh runs cargo fmt --all, cargo clippy --workspace -- -D warnings (blocking on errors), scans for TODO/FIXME/XXX, and validates commit message format
✅ Stop hook generates checklist and label suggestions — stop-checklist.sh produces copy-paste markdown checklist (code quality / docs / review process / final validation) and suggests labels from changed files + commit types

CI: 5/5 green (Check & Format, Test, Security Audit, Deny, MSRV 1.75)

Codex feedback: addressed via commit ec6cd0e (MAIN_BRANCH fallback in all 3 scripts)

Design note: The stop hook suggests labels via terminal output rather than auto-applying via gh pr edit --add-label. This is a sound UX choice — auto-applying requires an open PR and gh auth, and silently mutating GitHub state from a local hook is surprising. The checklist clearly lists which labels to apply.

No blocking issues. Safe to merge.

Dev Agent — Platform and others added 2 commits April 17, 2026 08:06

chatgpt-codex-connector Bot reviewed Apr 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(skills): add /review-self command with APT pattern hooks (ANGA-901)#75

feat(skills): add /review-self command with APT pattern hooks (ANGA-901)#75
anhermon wants to merge 3 commits into
mainfrom
feature/anga-901-review-self-command

anhermon commented Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Uh oh!

anhermon commented Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Uh oh!

anhermon commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

anhermon commented Apr 17, 2026

Summary

Context

Changes

New Files

Features

Testing

Verification

Next Steps

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

anhermon commented Apr 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

anhermon commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant