feat(cli): configurable subagent profiles with prompt/model/tool isolation (ANGA-807)#72
feat(cli): configurable subagent profiles with prompt/model/tool isolation (ANGA-807)#72anhermon wants to merge 1 commit into
Conversation
…ss (ANGA-807) Co-Authored-By: Paperclip <noreply@paperclip.ing>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97b098bfab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| let backend = self.config.provider.backend.as_str(); | ||
| let provider: anyhow::Result<Arc<dyn Provider>> = match backend { | ||
| "echo" => Ok(Arc::new(EchoProvider::new())), |
There was a problem hiding this comment.
EchoProvider is defined as a unit struct and has no new() associated function, so this call causes a compile-time error (no function or associated item named \new`) in harness-cli. Because this code is type-checked unconditionally in provider_for_subagent_profile`, the crate cannot build in any environment regardless of whether the echo backend is used at runtime.
Useful? React with 👍 / 👎.
anhermon
left a comment
anhermon
left a comment
There was a problem hiding this comment.
HOLD — P0 compile error flagged by Codex: EchoProvider is a unit struct with no new() function, causing a compile-time error in provider_for_subagent_profile. The crate cannot build. Fix: either use EchoProvider directly (no ::new()), or add impl EchoProvider { pub fn new() -> Self { EchoProvider } }. Do not merge until this is resolved.
1 participant
Summary
subagent_profilessupport to agent config, with fallback lookup fromagent.project_metadata.subagent_profilesspawn_subagenttool input to accept optionalprofile, and route sub-agent creation through profile-aware prompt/model/tool selectionspawn_subagentexecution when not registeredREADME.mdTesting
cargo fmtcargo test -p harness-cli(fails in this runtime: linkerccnot installed)