Support storage ID formats for NTFS and ChromeOS #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there are some storage IDs that don't match the format
ABCD-1234. For example, a USB drive with NTFS has a storage ID format consisting of a 16-digit hex string, likeA0E69251E6922814. Additionally, all external storages on ChromeOS, regardless of the filesystem they use, have a storage ID format that consists of a 40-digit hex string, such asBB146539D141DC32010CB1AD374464444024627A. Since I'm uncertain if there are other storage IDs with varying lengths, I've updated the regex to now accept any strings containing a combination of hex characters and dashes.