Skip to content

Fix 2048 game over logic#16

Open
anfernee wants to merge 1 commit into
masterfrom
fix-2048-game-over-17677514275306089276
Open

Fix 2048 game over logic#16
anfernee wants to merge 1 commit into
masterfrom
fix-2048-game-over-17677514275306089276

Conversation

@anfernee

Copy link
Copy Markdown
Owner
  • Added moves_available() to Grid to check if any empty tiles exist or adjacent tiles can be merged.
  • Modified Game.prototype.move() to trigger game over when no moves are available.
  • Fixed KeyboardManager.remove() to properly delete event listeners from this.events (using delete this.events[event] instead of .delete(), which fails since it's an Object, not a Map).

PR created automatically by Jules for task 17677514275306089276 started by @anfernee

Co-authored-by: anfernee <174200+anfernee@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant